mnl/VM-Operator
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 4 Wiki Activity Actions

Fix warnings.

Browse source
This commit is contained in:
Michael Lipp 2024-10-26 21:16:50 +02:00
parent 23703bad3c
commit 3708244571
3 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
org.jdrupes.vmoperator.runner.qemu/src/org/jdrupes/vmoperator/runner/qemu/QemuMonitor.java
View file

@ -238,6 +238,8 @@ public class QemuMonitor extends Component {
* @param event the event
*/
@Handler
@SuppressWarnings({ "PMD.AvoidSynchronizedStatement",
"PMD.AvoidDuplicateLiterals" })
public void onClosed(Closed<?> event, SocketIOChannel channel) {
channel.associated(QemuMonitor.class).ifPresent(qm -> {
monitorChannel = null;
@ -259,7 +261,8 @@ public class QemuMonitor extends Component {
* @param event the event
*/
@Handler
@SuppressWarnings("PMD.AvoidLiteralsInIfCondition")
@SuppressWarnings({ "PMD.AvoidLiteralsInIfCondition",
"PMD.AvoidSynchronizedStatement" })
public void onExecQmpCommand(MonitorCommand event) {
var command = event.command();
logger.fine(() -> "monitor(out): " + command.toString());
@ -290,6 +293,7 @@ public class QemuMonitor extends Component {
* @param event the event
*/
@Handler(priority = 100)
@SuppressWarnings("PMD.AvoidSynchronizedStatement")
public void onStop(Stop event) {
if (monitorChannel != null) {
// We have a connection to Qemu, attempt ACPI shutdown.
@ -321,6 +325,7 @@ public class QemuMonitor extends Component {
* @param event the event
*/
@Handler
@SuppressWarnings("PMD.AvoidSynchronizedStatement")
public void onPowerdownEvent(PowerdownEvent event) {
synchronized (this) {
// Cancel confirmation timeout
@ -349,6 +354,7 @@ public class QemuMonitor extends Component {
* @param event the event
*/
@Handler
@SuppressWarnings("PMD.AvoidSynchronizedStatement")
public void onConfigureQemu(ConfigureQemu event) {
int newTimeout = event.configuration().vm.powerdownTimeout;
if (powerdownTimeout != newTimeout) {

5
org.jdrupes.vmoperator.runner.qemu/src/org/jdrupes/vmoperator/runner/qemu/Runner.java
View file

@ -41,8 +41,8 @@ import java.nio.file.Path;
import java.nio.file.Paths;
import java.time.Instant;
import java.util.Comparator;
import java.util.EnumSet;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Optional;
import java.util.Set;
import java.util.logging.Level;
@ -227,7 +227,7 @@ public class Runner extends Component {
CloudInit
}
private final Set<QemuPreps> qemuLatch = new HashSet<>();
private final Set<QemuPreps> qemuLatch = EnumSet.noneOf(QemuPreps.class);
/**
* Instantiates a new runner.
@ -483,6 +483,7 @@ public class Runner extends Component {
mayBeStartQemu(QemuPreps.Config);
}
@SuppressWarnings("PMD.AvoidSynchronizedStatement")
private void mayBeStartQemu(QemuPreps done) {
synchronized (qemuLatch) {
if (qemuLatch.isEmpty()) {